Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 )
Change subject: IMPALA-5237: Support a quoted string in date/time format ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8508/9/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/8508/9/be/src/runtime/timestamp-parse-util.cc@175 PS9, Line 175: // quote due to the compatibility with Hive's behavior. > Why do we display a single quote in the middle of the string if we have to > split "'foo''bar'" into 'foo' and 'bar'? The reason this PS and the previous produced the correct result is that they split foo''bar into two tokens foo' and bar. > Could you please explain why we cannot convert into a single token without > creating a new string and copying the data? If we need a pair of alloc and > memcpy for new tokens, this is not related to the number of broken tokens. Suppose you want to take the input string foo''bar and convert the '' escape sequence to '. If you want to produce a single output token, you need it to be foo'bar, which which you can't represent as a pointer into the original string + a length. -- To view, visit http://gerrit.cloudera.org:8080/8508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 Gerrit-Change-Number: 8508 Gerrit-PatchSet: 9 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 06 Mar 2018 01:43:25 +0000 Gerrit-HasComments: Yes
