Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9300 )

Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3
......................................................................


Patch Set 8:

(2 comments)

Once you address my comments below, please rebase with the master branch as 
that has KRPC enabled by default and make sure that both secure and non-secure 
environments run properly.

http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc
File be/src/rpc/thrift-server.cc:

http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc@77
PS7, Line 77: r (const auto& prot
> Removed. Thrift added this enum and I was not sure whether it should be her
I just realized. We need to maintain parity with KRPC as well:
https://github.com/apache/kudu/blob/2a5a12fbd69882b387f83e1da71d8a0fd19b6a63/src/kudu/server/server_base.cc#L168-L173

This means that we cannot use the SSLTLS option too. Let's just stick with 
TLSv1_0, TLSv1_1, and TLSv1_2.

In that case, we can leave the 'ssl_minimum_version' flag as it is.


http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc@99
PS7, Line 99: return true;
> I mean  protocol == SSLTLS || protocol == TLSv1_0 || protocol == TLSv1_1
Yup, this is right, but will now need to change anyway because we'll need to 
get rid of SSLTLS.



--
To view, visit http://gerrit.cloudera.org:8080/9300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
Gerrit-Change-Number: 9300
Gerrit-PatchSet: 8
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: anujphadke <apha...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 18:37:00 +0000
Gerrit-HasComments: Yes

Reply via email to