Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 )
Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9508/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/9508/1/be/src/exprs/expr-test.cc@8351 PS1, Line 8351: TimestampValue::Parse("2110-01-01 00:00:00")); > please double check the behavior of DECADE, CENTURY and MILLENNIUM against We already depend on PostgreSQL in development environments because of the minicluster. Should we go full-hog and compare results at test time? -- To view, visit http://gerrit.cloudera.org:8080/9508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f4aac17875dbf17dcabff25473ffeb006fce20b Gerrit-Change-Number: 9508 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 18:45:52 +0000 Gerrit-HasComments: Yes
