Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9506 )

Change subject: IMPALA-6610: Impala shell fetches the value of 
ldap_password_cmd incorrectly
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9506/1/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9506/1/shell/impala_shell.py@1539
PS1, Line 1539:       options.ldap_password = options.ldap_password.strip('\n')
You should only strip the new line when there's no error. Move line: 1539 to 
line: 1544.



--
To view, visit http://gerrit.cloudera.org:8080/9506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7
Gerrit-Change-Number: 9506
Gerrit-PatchSet: 1
Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 20:00:11 +0000
Gerrit-HasComments: Yes

Reply via email to