Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl@230 PS11, Line 230: $.map(json["per_conn_metrics"], function(row) { : return [$.map(row, function(cell) { return cell; })]; > The 'keys' var is what we use to index into the JSON. If we add/remove a fi If we remove fields being presented in the table or add new fields to the table, we would have to update the table layout anyway. So, I don't see it being a big deal to also update this function. IMHO, the code is much easier to follow if we explicitly specify the keys to index into JSON than having the ordering of the fields implicitly encoded in rpc-mgr.cc. -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 11 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 06 Mar 2018 22:03:32 +0000 Gerrit-HasComments: Yes
