Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9501 )

Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState
......................................................................


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/9501/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9501/2//COMMIT_MSG@11
PS2, Line 11: for a future change
Do we have a JIRA for this?


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:

http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h@344
PS2, Line 344:   /// We enforce the invariant that query_status_ is not OK iff 
operation_state_ is
nit: add line


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h@345
PS2, Line 345: query_state_
operation_state_


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h@405
PS2, Line 405: status_
query_status_


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h@405
PS2, Line 405: query_state_
operation_state_


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h@408
PS2, Line 408: status_
query_status_


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.h@450
PS2, Line 450: apache::hive::service::cli::thrift::
Are we against adding "using namespace ..." in a header file?


http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/9501/2/be/src/service/client-request-state.cc@1109
PS2, Line 1109: "Query State"
Do we want to leave this as "Query State" after deprecating beeswax? Or change 
it to "Operation State" ?



--
To view, visit http://gerrit.cloudera.org:8080/9501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36287eaf8f1dac23c306b470f95f379dfdc6bb5b
Gerrit-Change-Number: 9501
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 00:24:01 +0000
Gerrit-HasComments: Yes

Reply via email to