Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 )
Change subject: IMPALA-6337: Fix infinite loop in Impala shell ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9195/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9195/9/shell/impala_shell.py@588 PS9, Line 588: for index in xrange(0, len(parsed_statements)): > Isn't xrange is faster in Python 2.7 compared to enumerate? It probably is faster, but I don't think performance should be a concern in this case. If you want to keep xrange(), then you can get rid of the first argument. xrange(len(parsed_statements)) -- To view, visit http://gerrit.cloudera.org:8080/9195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b Gerrit-Change-Number: 9195 Gerrit-PatchSet: 9 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 00:24:20 +0000 Gerrit-HasComments: Yes