Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9527 )

Change subject: IMPALA-6609: Fix ownership of class members in 
KrpcDataStreamRecvr
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9527/1/be/src/runtime/krpc-data-stream-recvr.h
File be/src/runtime/krpc-data-stream-recvr.h:

http://gerrit.cloudera.org:8080/#/c/9527/1/be/src/runtime/krpc-data-stream-recvr.h@197
PS1, Line 197:   /// 'recvr_side_profile_' and 'sender_side_profile_'. Not 
owned.
> It's pretty critical that 'recvr_side_profile_' and "sender_side_profile_'
I believe so by the virtue that the receiver is co-owned by the exchange node 
and the data stream manager. So, the receiver will have a lifetime of at least 
as long as the exchange node's.

'profile_' and the exchange node are both owned by the RuntimeState's 'pool_' 
so 'profile_' lifetime should be no longer than that of the exchange node.

Combining the above and the fact that 'recvr_side_profile_' and 
'sender_side_profile_'  are owned by the receiver, they should have a lifetime 
at least as long as 'profile_'.

Will add a comment about this requirement in PS2.



--
To view, visit http://gerrit.cloudera.org:8080/9527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3378496e2201b16c662b9daa634333480705c61a
Gerrit-Change-Number: 9527
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 07:16:41 +0000
Gerrit-HasComments: Yes

Reply via email to