Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9514 )

Change subject: IMPALA-6605: Exception hidden on complex types
......................................................................


Patch Set 4:

(2 comments)

Couple nits.

http://gerrit.cloudera.org:8080/#/c/9514/4/fe/src/main/java/org/apache/impala/common/AnalysisException.java
File fe/src/main/java/org/apache/impala/common/AnalysisException.java:

http://gerrit.cloudera.org:8080/#/c/9514/4/fe/src/main/java/org/apache/impala/common/AnalysisException.java@27
PS4, Line 27: candidatePath
Private variables end in "_".


http://gerrit.cloudera.org:8080/#/c/9514/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/9514/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@576
PS4, Line 576: "'functional.allcomplextypes.int_struct_col'")
Fix indent.



--
To view, visit http://gerrit.cloudera.org:8080/9514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ae62fe63b82899d1467a23422d4a73f1471aa84
Gerrit-Change-Number: 9514
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 16:31:06 +0000
Gerrit-HasComments: Yes

Reply via email to