Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9484 )

Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL
......................................................................


Patch Set 1: Code-Review+2

> I am not sure how valid the results/reproducible are but I ran a
 > perf test on a single host and here are the results:
 > https://drive.google.com/file/d/1SR7SPQ8Hd_pGJ22QSL1kP9nflCFn8Ql9/view?usp=sharing
 >
 > I haven't analyzed what could cause the slowdown in the 2 or  3
 > queries most impacted yet. It could be min/max filters or perhaps
 > more expensive algebra functions.

Thanks for taking a look. Seems like the queries that slowed down are all 
performing a lot of DECIMAL arithmetic, which of course is going to be slower 
than DOUBLE arithmetic.

And of course, we need to make this change even if its a regression so that we 
match the tpc spec.


--
To view, visit http://gerrit.cloudera.org:8080/9484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f7e4464dc6705cadd610a82c459390a9c0dfe4f
Gerrit-Change-Number: 9484
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 18:42:07 +0000
Gerrit-HasComments: No

Reply via email to