Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 )
Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners ...................................................................... Patch Set 7: > I'm still seeing crashes when I loop this locally: > F0306 16:34:04.306205 29911 mem-pool.h:245] Check failed: size >= 0 > (-9 vs. 0) > *** Check failure stack trace: *** > @ 0x3c32cbd google::LogMessage::Fail() > @ 0x3c34562 google::LogMessage::SendToLog() > @ 0x3c32697 google::LogMessage::Flush() > @ 0x3c35c5e google::LogMessageFatal::~LogMessageFatal() > @ 0x184eeb4 impala::MemPool::TryAllocate() > @ 0x1be5d08 impala::HdfsRCFileScanner::StartRowGroup() > @ 0x1be8032 impala::HdfsRCFileScanner::ProcessRange() > @ 0x296931a impala::BaseSequenceScanner::GetNextInternal() > @ 0x1bc71b2 impala::HdfsScanner::ProcessSplit() > @ 0x1b9f48c impala::HdfsScanNode::ProcessSplit() > @ 0x1b9e8b7 impala::HdfsScanNode::ScannerThread() > @ 0x1b9dd3f > _ZZN6impala12HdfsScanNode22ThreadTokenAvailableCbEPNS_17ThreadResourceMgr12ResourcePoolEENKUlvE_clEv > @ 0x1b9fcdd > _ZN5boost6detail8function26void_function_obj_invoker0IZN6impala12HdfsScanNode22ThreadTokenAvailableCbEPNS3_17ThreadResourceMgr12ResourcePoolEEUlvE_vE6invokeERNS1_15function_bufferE > @ 0x17f4ce0 boost::function0<>::operator()() > @ 0x1af63ff impala::Thread::SuperviseThread() > @ 0x1aff3cf boost::_bi::list5<>::operator()<>() > @ 0x1aff2f3 boost::_bi::bind_t<>::operator()() > @ 0x1aff2b6 boost::detail::thread_data<>::run() > @ 0x2dbc1aa thread_proxy > @ 0x7f5af8f926ba start_thread > @ 0x7f5af8cc841d clone > Picked up JAVA_TOOL_OPTIONS: > -agentlib:jdwp=transport=dt_socket,address=30000,server=y,suspend=n > Wrote minidump to > /home/tarmstrong/Impala/incubator-impala/logs/cluster/minidumps/impalad/31a8ae22-6a2a-4118-4ff4e1b6-be18ef7c.dmp > > How about we leave the test disabled and move forward with the > improvements, then we can finish up the remaining fixes needed > later? Shall I revert my changes to tests/query_test/test_scanners_fuzz.py ? -- To view, visit http://gerrit.cloudera.org:8080/8936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9cfc38af3f30c65ada9734eb471dbfa6ecdd74a Gerrit-Change-Number: 8936 Gerrit-PatchSet: 7 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 18:56:03 +0000 Gerrit-HasComments: No
