Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 )
Change subject: IMPALA-6602: fixes flaky expiration test ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9538/1/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/9538/1/tests/custom_cluster/test_query_expiration.py@80 PS1, Line 80: assert (client.get_state(short_timeout_expire_handle) == > my thought here is that we think we wait enough so that we're just looking Ah yeah, that makes sense. http://gerrit.cloudera.org:8080/#/c/9538/1/tests/custom_cluster/test_query_expiration.py@175 PS1, Line 175: def __expect_client_state(self, client, handle, expected_state, max_tries=10): > we're doing an rpc for this one so I thought it should be slow enough. sinc I'm ok with a time bound. I don't think it needs to be too loose, since cancellation should happen as soon as one of the cancellation threads is scheduled. 10s of milliseconds seems reasonable. -- To view, visit http://gerrit.cloudera.org:8080/9538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aabed87d84d5cfd8078cc6c39df48e22ff30afc Gerrit-Change-Number: 9538 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 08 Mar 2018 00:11:35 +0000 Gerrit-HasComments: Yes
