Hello Zoltan Borok-Nagy,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9500
to look at the new patch set (#3).
Change subject: IMPALA-6592: add test for invalid parquet codecs
......................................................................
IMPALA-6592: add test for invalid parquet codecs
IMPALA-6592 revealed a gap in test coverage for files with
invalid/unsupported Parquet codecs. This adds a test that reproduces the
bug that was present in my IMPALA-4835 patch. master is unaffected by
this bug.
I also hid the conversion tables and made the conversion go through
functions that validate the enum values, to make it easier to track down
problems like this in the future.
Testing:
Ran exhaustive tests.
Change-Id: I1502ea7b7f39aa09f0ed2677e84219b37c64c416
---
M be/src/exec/CMakeLists.txt
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/exec/parquet-column-readers.h
A be/src/exec/parquet-common.cc
M be/src/exec/parquet-common.h
M be/src/util/parquet-reader.cc
M testdata/data/README
A testdata/data/bad_codec.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bad-codec.test
M tests/query_test/test_scanners.py
10 files changed, 136 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/9500/3
--
To view, visit http://gerrit.cloudera.org:8080/9500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1502ea7b7f39aa09f0ed2677e84219b37c64c416
Gerrit-Change-Number: 9500
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
