David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9537 )
Change subject: IMPALA-6615: CTE query in Impala shell does not show query web links ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9537/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9537/1/shell/impala_shell.py@1131 PS1, Line 1131: return self._execute_stmt(query, is_dml=is_dml, print_web_link=is_dml) > I guess my question is: why are we not passing print_web_links=True here? W My guess is that not every query containing a WITH clause is DML, and if not, then print_web_link should be False. In other words, we either want: self._execute_stmt(query, True, True) or self._execute_stmt(query, False, False) but never self._execute_stmt(query, False, True) -- To view, visit http://gerrit.cloudera.org:8080/9537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3352406e3b048be395a20405c8e6b911e663164 Gerrit-Change-Number: 9537 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Thu, 08 Mar 2018 07:20:30 +0000 Gerrit-HasComments: Yes
