Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9538 )
Change subject: IMPALA-6602: fixes flaky expiration test ...................................................................... IMPALA-6602: fixes flaky expiration test The test_query_expiration test assumes that a metric and the query state are maintained atomically. Since they're not, occasionaly flakes (false negatives) occur. The fix in this patch is to loop until the expected state is seen. If the expected state is not seen with a given number of iterations, the test fails. These tests depend on timing so if this validation takes too long, the test will also fail. Such looping is used in the two places where its assumed that the client state and metrics are maintained atomically. Change-Id: I7aabed87d84d5cfd8078cc6c39df48e22ff30afc Reviewed-on: http://gerrit.cloudera.org:8080/9538 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_query_expiration.py 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7aabed87d84d5cfd8078cc6c39df48e22ff30afc Gerrit-Change-Number: 9538 Gerrit-PatchSet: 5 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
