Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 )
Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9556/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/9556/1/be/src/exec/parquet-column-readers.cc@a175 PS1, Line 175: > Nit: good to check that num_cached_levels GE 0 My guess is that this can occur if a corrupt Parquet file contains a literal count with value 0 (coded as 0x01) and FillCache was last called via ParquetLevelDecoder::ReadLevel(). FillCache should return false in this case, and ReadLevel()'s caller, BaseScalarColumnReader::NextLevels() should check for HdfsParquetScanner::INVALID_LEVEL. This way a proper warning/error could be returned instead of crashing. -- To view, visit http://gerrit.cloudera.org:8080/9556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd6e09f8c8cca8991be5b5b379f6420adaa97daa Gerrit-Change-Number: 9556 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Thu, 08 Mar 2018 20:51:49 +0000 Gerrit-HasComments: Yes
