Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9300 )

Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.h
File be/src/rpc/thrift-server.h:

http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.h@323
PS7, Line 323: TLSv1_0
> Done
I don't understand why it's equivalent. In 0.9.0 TLSv1_method() is called here 
https://github.com/apache/thrift/blob/0.9.x/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L60,
 but SSLTLS in 0.9.3 correspond to TLSv23_method().


http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc
File be/src/rpc/thrift-server.cc:

http://gerrit.cloudera.org:8080/#/c/9300/7/be/src/rpc/thrift-server.cc@99
PS7, Line 99: return protocol != SSLv3 && protocol != TLSv1_2;
> I think we still need SSLTLS at https://gerrit.cloudera.org/c/9300/7/be/src
Do we still need SSLTLS here?
 https://gerrit.cloudera.org/c/9300/7/be/src/rpc/thrift-server.h#323



--
To view, visit http://gerrit.cloudera.org:8080/9300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
Gerrit-Change-Number: 9300
Gerrit-PatchSet: 7
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: anujphadke <apha...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 19:43:37 +0000
Gerrit-HasComments: Yes

Reply via email to