Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 )
Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 ...................................................................... Patch Set 2: (1 comment) > We should also document the following new option which changes the > set reserved words for compatibility. We should be explicit that > this option is intended to buy existing users some time, and that > we plan to eventually remove this option altogether. > > DEFINE_string(reserved_words_version, "3.0.0", "Reserved words > compatibility version. " > "Reserved words cannot be used as identifiers in SQL. This flag > determines the impala" > " version from which the reserved word list is taken. The value > must be one of " > "[\"2.11.0\", \"3.0.0\"]."); > We should also document the following new option which changes the > set reserved words for compatibility. We should be explicit that > this option is intended to buy existing users some time, and that > we plan to eventually remove this option altogether. > > DEFINE_string(reserved_words_version, "3.0.0", "Reserved words > compatibility version. " > "Reserved words cannot be used as identifiers in SQL. This flag > determines the impala" > " version from which the reserved word list is taken. The value > must be one of " > "[\"2.11.0\", \"3.0.0\"]."); I mentioned this option in the upgrade guide. Since it is only a temporary option, I don't think it should be in this doc. http://gerrit.cloudera.org:8080/#/c/9540/2/docs/topics/impala_reserved_words.xml File docs/topics/impala_reserved_words.xml: http://gerrit.cloudera.org:8080/#/c/9540/2/docs/topics/impala_reserved_words.xml@71 PS2, Line 71: <codeblock rev="ver"> > Please ignore, sorry. Done -- To view, visit http://gerrit.cloudera.org:8080/9540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09dbaf5e2d22f07a8bca8a601c04e94f3a4b36a0 Gerrit-Change-Number: 9540 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Fri, 09 Mar 2018 19:45:02 +0000 Gerrit-HasComments: Yes
