Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 )
Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9527/4/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/9527/4/be/src/runtime/krpc-data-stream-recvr.cc@465 PS4, Line 465: // TakeOverEarlySender() is called by the same thread which calls Close(). : // The receiver cannot be closed while this function is in progress so : // 'recvr_->mgr_' shouldn't be NULL. : DCHECK(TestInfo::is_test() || FragmentInstanceState::IsFragmentExecThread()); : DCHECK(!recvr_->closed_ && recvr_->mgr_ != nullptr); > Moved the DCHECKs. can still cancel* this sender queue -- To view, visit http://gerrit.cloudera.org:8080/9527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3378496e2201b16c662b9daa634333480705c61a Gerrit-Change-Number: 9527 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Mar 2018 02:51:46 +0000 Gerrit-HasComments: Yes
