Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 )
Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9578/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9578/1//COMMIT_MSG@8 PS1, Line 8: > Could you add a little more color here, eg. "This patch enables pushing sca Done http://gerrit.cloudera.org:8080/#/c/9578/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test: http://gerrit.cloudera.org:8080/#/c/9578/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test@553 PS1, Line 553: # Decimal InList predicate. > There's an existing test in 'PlannerTest/kudu-selectivity.test' (around lin I can't add the column there because the functional alltypes table doesn't actually contain all types and adding the decimal type would be extremely invasive given how widely used that table is in tests. I could move this test to that location if you prefer, but it would still be stand alone. -- To view, visit http://gerrit.cloudera.org:8080/9578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2569a9e1d58f1c58884d58633d46348364888ed7 Gerrit-Change-Number: 9578 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 19:13:37 +0000 Gerrit-HasComments: Yes
