Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 )
Change subject: IMPALA-5315: Cast to timestamp fails for YYYY-M-D format ...................................................................... Patch Set 16: (4 comments) Changed the name of the e2e test to be more appropriate for its purpose. http://gerrit.cloudera.org:8080/#/c/7009/16/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/7009/16/be/src/runtime/timestamp-parse-util.cc@28 PS16, Line 28: #include <algorithm> > Standard C++ headers go before the 3rd-party library headers. I.e. line 19 Done http://gerrit.cloudera.org:8080/#/c/7009/16/testdata/workloads/functional-query/queries/QueryTest/cast-lazy-datetime-string.test File testdata/workloads/functional-query/queries/QueryTest/cast-lazy-datetime-string.test: http://gerrit.cloudera.org:8080/#/c/7009/16/testdata/workloads/functional-query/queries/QueryTest/cast-lazy-datetime-string.test@3 PS16, Line 3: select cast(dt_str as timestamp) from lazy_dt_str > should not need a cast here, we want to test the text scanner parsing the d Done http://gerrit.cloudera.org:8080/#/c/7009/16/testdata/workloads/functional-query/queries/QueryTest/cast-lazy-datetime-string.test@4 PS16, Line 4: ---- RESULTS > Let's make this RESULTS: VERIFY_IS_EQUAL_SORTED Done http://gerrit.cloudera.org:8080/#/c/7009/16/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/7009/16/tests/query_test/test_scanners.py@874 PS16, Line 874: STRING > This should be a timestamp column, so we can make sure that the text scanne Done -- To view, visit http://gerrit.cloudera.org:8080/7009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f Gerrit-Change-Number: 7009 Gerrit-PatchSet: 16 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Tue, 13 Mar 2018 00:23:33 +0000 Gerrit-HasComments: Yes
