Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9589 )

Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9589/7/fe/src/main/java/org/apache/impala/authorization/Privilege.java
File fe/src/main/java/org/apache/impala/authorization/Privilege.java:

http://gerrit.cloudera.org:8080/#/c/9589/7/fe/src/main/java/org/apache/impala/authorization/Privilege.java@51
PS7, Line 51:     SELECT("select"),
> I created a new enum that implements Sentry's Action to decouple Impala fro
Can you add a comment for this enum with the above?  Maybe also include that we 
can add privileges that are specific to Impala, i.e. refresh metadata.


http://gerrit.cloudera.org:8080/#/c/9589/7/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
File fe/src/test/java/org/apache/impala/analysis/ParserTest.java:

http://gerrit.cloudera.org:8080/#/c/9589/7/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3578
PS7, Line 3578: // REFRESH METADATA privilege.
The tests right below this section indicate that server scope does not accept a 
name.  Did that change? Is the comment below incorrect? or should we add 
ParserError tests if a server name is passed in?



--
To view, visit http://gerrit.cloudera.org:8080/9589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4
Gerrit-Change-Number: 9589
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Adam Holley <g...@holleyism.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 18:28:35 +0000
Gerrit-HasComments: Yes

Reply via email to