Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9614 )
Change subject: DRAFT IMPALA-5973: Provide query plan in JSON format. ...................................................................... Patch Set 1: - High-level comment: It seems kind of redundant that we build the explain string and Map at the same time for every getExplainString*(). Maybe we should have an intermediate state that we can convert to both text-plan and JSON depending on the caller. Seems like Map would be the obvious choice (guava has helper methods to build the explain string from Map) and obviously we can build a JSON string. - Please add a web endpoint for the json profile (something like query_profile?json) to make it easy to consume and write e-e tests. Alex, does the approach sound ok, or do you think it can be done in any better way? -- To view, visit http://gerrit.cloudera.org:8080/9614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7429ac1e93a9c524233383cafd387056fcf2542d Gerrit-Change-Number: 9614 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Mar 2018 16:31:34 +0000 Gerrit-HasComments: No
