Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9631 )
Change subject: IMPALA-5270: Pass resolved exprs into analytic SortInfo. ...................................................................... Patch Set 2: (1 comment) thanks for the changes. one more question about broadening the test coverage. http://gerrit.cloudera.org:8080/#/c/9631/2/testdata/workloads/functional-planner/queries/PlannerTest/sort-expr-materialization.test File testdata/workloads/functional-planner/queries/PlannerTest/sort-expr-materialization.test: http://gerrit.cloudera.org:8080/#/c/9631/2/testdata/workloads/functional-planner/queries/PlannerTest/sort-expr-materialization.test@202 PS2, Line 202: # IMPALA-5270: Rand() and udf inside inline view referenced by analytic function. are there are other cases that could have tripped for similar reasons? perhaps: - instead of an inline view, a with statement - an inline view that is nested multiple levels deep (udfs/non-det used in the inner most nesting level) -- To view, visit http://gerrit.cloudera.org:8080/9631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2b3f4e5e3f1fd441a63160db3c703c432fbb072 Gerrit-Change-Number: 9631 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 20:55:21 +0000 Gerrit-HasComments: Yes
