anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 )
Change subject: IMPALA-5695: restart_first_impalad() does not start impalad ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py@80 PS1, Line 80: IMPALA_HOME = os.environ['IMPALA_HOME'] : IMPALAD_PATH = os.path.join(IMPALA_HOME, : 'bin/start-impalad.sh --server_name=server1') > Could we get this data from /proc/<pid>/environ as part of refresh? The restart method in impala_cluster.py seems to be extracting this path from psutil.Process. The issue in doing this is it wont set the classpath correctly and impalad will exit out failing to find JNI. The restart method defined in Process seems to be more generic. It uses cmdline to start the process. So I didn't want to hardcode this script path there. -- To view, visit http://gerrit.cloudera.org:8080/9619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875 Gerrit-Change-Number: 9619 Gerrit-PatchSet: 1 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Mar 2018 22:41:46 +0000 Gerrit-HasComments: Yes
