Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 )
Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 ...................................................................... Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9540/8/docs/topics/impala_reserved_words.xml File docs/topics/impala_reserved_words.xml: http://gerrit.cloudera.org:8080/#/c/9540/8/docs/topics/impala_reserved_words.xml@3118 PS8, Line 3118: <entry><codeph>set</codeph></entry> > The clause is GROUPING SETS, of course I checked a few other DBs and SETS seems to be generally not reserved. Let me check with Tianyi about adding additional reserved words. I think the current table reflects the current reality, so should be good to merge, but we will very likely add some more words soon. -- To view, visit http://gerrit.cloudera.org:8080/9540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09dbaf5e2d22f07a8bca8a601c04e94f3a4b36a0 Gerrit-Change-Number: 9540 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:26:42 +0000 Gerrit-HasComments: Yes
