Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 )
Change subject: IMPALA-5717: Support for reading ORC data files ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9134/5/testdata/bin/load_nested.py File testdata/bin/load_nested.py: http://gerrit.cloudera.org:8080/#/c/9134/5/testdata/bin/load_nested.py@297 PS5, Line 297: def load_orc(): > I don't think this is the best way to load the data - I think we should add We have several tables in the functional-query dataset that use complex types. I think it would make sense to extend those to do ORC. For example, complextypes_fileformat is used for positive/negative testing of nested types for each file format. complextypes_multifileformat does something similar at a partition level. I think it would make sense for both of these to incorporate ORC. (See testdata/dataset/functional/functional_schema_template.sql) complextypes_fileformat is used in our frontend planner tests that exercise the planner without the rest of execution. See fe/src/test/java/org/apache/impala/planner/PlannerTest.java. The specific test that uses complextypes_fileformat is testComplexTypesFileFormat(), which references testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test. This test is doing a similar check to what you are doing in nested-types-orc-basic.test, so I think it would make sense to incorporate that test into testComplexTypesFileFormat(). -- To view, visit http://gerrit.cloudera.org:8080/9134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4 Gerrit-Change-Number: 9134 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 17:03:48 +0000 Gerrit-HasComments: Yes
