Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9637 )
Change subject: IMPALA-6655: Add owner information on database creation ...................................................................... Patch Set 1: (2 comments) Looks good to me as well, will merge after the final touches http://gerrit.cloudera.org:8080/#/c/9637/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9637/1//COMMIT_MSG@13 PS1, Line 13: +---------+----------+---------+ Not really related to your change, but our describe database looks a little strange. It's also quite different from Hive's output which looks nicer imo. Let's not make any changes to the output in this patch. But can you file a JIRA to reconsider our output? http://gerrit.cloudera.org:8080/#/c/9637/1/fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java: http://gerrit.cloudera.org:8080/#/c/9637/1/fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java@111 PS1, Line 111: Preconditions.checkNotNull(owner_); condense into a single line: public String getOwner() { return Preconditions.checkNotNull(owner_); } -- To view, visit http://gerrit.cloudera.org:8080/9637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78 Gerrit-Change-Number: 9637 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 05:40:55 +0000 Gerrit-HasComments: Yes
