Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9718 )
Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances ...................................................................... Patch Set 1: Some context. This change was already submitted once: https://gerrit.cloudera.org/#/c/8997/ but was reverted when a crash was seen in builds: https://issues.apache.org/jira/browse/IMPALA-6484 The new version of the patch has two changes from the old version: - I removed the path in Coordinator::UpdateBackendExecStatus that returned early if the overall query status was already Cancelled. This was a performance optimization, but I think it wasn't really a valid thing to do as query_status_ is supposed to be protected by Coordinator::lock_ - I added locking of BackendStates to Coordinator::ComputeQuerySummary. This prevents the race condition that the original patch was reverted for. -- To view, visit http://gerrit.cloudera.org:8080/9718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f8295e4ec580b476f7668c77aec1348fb2e868c Gerrit-Change-Number: 9718 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 19 Mar 2018 22:52:51 +0000 Gerrit-HasComments: No
