Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9589 )

Change subject: IMPALA-6643: Add REFRESH fine-grained privilege
......................................................................


Patch Set 18:

(3 comments)

Good to go after this

http://gerrit.cloudera.org:8080/#/c/9589/18/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

http://gerrit.cloudera.org:8080/#/c/9589/18/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@104
PS18, Line 104:   //   REFRESH permissions on 'functional_text_lzo' database
These are generally clustered by table and not by privilege (suggested changes 
below)


http://gerrit.cloudera.org:8080/#/c/9589/18/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@105
PS18, Line 105:   //   REFRESH permissions on 'functional.alltypesagg' table
combine with L88


http://gerrit.cloudera.org:8080/#/c/9589/18/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@106
PS18, Line 106:   //   REFRESH permissions on 'functional.view_view' view
combine with L90



--
To view, visit http://gerrit.cloudera.org:8080/9589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4
Gerrit-Change-Number: 9589
Gerrit-PatchSet: 18
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Adam Holley <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Tue, 20 Mar 2018 04:06:16 +0000
Gerrit-HasComments: Yes

Reply via email to