Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9728 )
Change subject: IMPALA-6687: Fix INSERT with mixed case partition column name ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9728/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/9728/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@335 PS1, Line 335: if (!mentionedColumnNames.add(column.getName())) { wow, nice catch http://gerrit.cloudera.org:8080/#/c/9728/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/9728/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@3330 PS1, Line 3330: "partition (YEAR, month)" + I thought the bug was specific to partition columns mentioned in the columns list and not the partition clause? Or are you just generally expanding the coverage here? -- To view, visit http://gerrit.cloudera.org:8080/9728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6975c2978850381904a45107f76850640aff52e Gerrit-Change-Number: 9728 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 23:10:33 +0000 Gerrit-HasComments: Yes
