Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/9716 )
Change subject: IMPALA-4277: Support multiple versions of Hadoop ecosystem
......................................................................
Patch Set 2:
(5 comments)
Thanks for your review Tim!
I've taken your suggestions. I also found another test that needed amending:
AuthorizationTest. I missed it because it was introduced recently
("IMPALA-6479: Update DESCRIBE to respect column privileges") and I'd started
this change before it was in the code base.
http://gerrit.cloudera.org:8080/#/c/9716/2/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/SentryAuthProvider.java
File
fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/SentryAuthProvider.java:
http://gerrit.cloudera.org:8080/#/c/9716/2/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/SentryAuthProvider.java@73
PS2, Line 73: new Object[] {policyFile, engine,
HivePrivilegeModel.getInstance()});
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/9716/2/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java
File fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:
http://gerrit.cloudera.org:8080/#/c/9716/2/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java@398
PS2, Line 398: return
Lists.newArrayList(SentryUtil.listRoles(client.get(),
requestingUser.getShortName()));
> nit: long line
Done
http://gerrit.cloudera.org:8080/#/c/9716/2/testdata/workloads/functional-query/queries/QueryTest/parquet-filtering.test
File
testdata/workloads/functional-query/queries/QueryTest/parquet-filtering.test:
http://gerrit.cloudera.org:8080/#/c/9716/2/testdata/workloads/functional-query/queries/QueryTest/parquet-filtering.test@368
PS2, Line 368: set parquet_read_statistics=0;
> This isn't needed, right, since it's already set in Python.
Done
http://gerrit.cloudera.org:8080/#/c/9716/2/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
http://gerrit.cloudera.org:8080/#/c/9716/2/tests/query_test/test_mt_dop.py@103
PS2, Line 103: vector.get_value('exec_option')['parquet_read_statistics'] =
'0'
> Comment here to explain why, e.g. "Disable min-max stats to prevent interfe
Done
http://gerrit.cloudera.org:8080/#/c/9716/2/tests/query_test/test_partitioning.py
File tests/query_test/test_partitioning.py:
http://gerrit.cloudera.org:8080/#/c/9716/2/tests/query_test/test_partitioning.py@68
PS2, Line 68: is_hive_2 = os.environ.get("IMPALA_MINICLUSTER_PROFILE",
None) == "3"
> Can we move this to a helper function in tests/common/environ.py. It's some
Done
--
To view, visit http://gerrit.cloudera.org:8080/9716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2ab50331986c7394c2bbfd6c865232bca975f7
Gerrit-Change-Number: 9716
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 21 Mar 2018 03:41:13 +0000
Gerrit-HasComments: Yes
