Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 )
Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 ...................................................................... Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/9696/2/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9696/2/be/CMakeLists.txt@341 PS2, Line 341: krb5_get_init_creds_opt_set_fast_ccache_name I manually confirmed that this function is not defined in the source code https://github.com/krb5/krb5/tree/krb5-1.6/src but defined in https://github.com/krb5/krb5/tree/krb5-1.7/src. It'd be nice to do an objdump of the kerberos shared library on vanilla SLES11 and Centos6.4 to confirm they match our expectation. http://gerrit.cloudera.org:8080/#/c/9696/2/be/src/kudu/rpc/messenger.cc File be/src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/9696/2/be/src/kudu/rpc/messenger.cc@279 PS2, Line 279: Since we support SLES11, we omit We omit calling ... http://gerrit.cloudera.org:8080/#/c/9696/2/be/src/kudu/rpc/messenger.cc@282 PS2, Line 282: omiting nit: omitting http://gerrit.cloudera.org:8080/#/c/9696/2/be/src/kudu/rpc/messenger.cc@290 PS2, Line 290: Is it worth adding a quick log statement to indicate that we are skipping PreflightCheckGSSAPI() ? -- To view, visit http://gerrit.cloudera.org:8080/9696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4cc7f0702f605fca02a2ff5d3d2735e6e080668 Gerrit-Change-Number: 9696 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 21 Mar 2018 05:31:58 +0000 Gerrit-HasComments: Yes
