Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9748 )
Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9748/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9748/1//COMMIT_MSG@48 PS1, Line 48: - rpc-test.cc has changed some CHECKs to ASSERTs : throughout. I brought in TestRpcSidecarLimits : exactly as it is in Kudu. Relevant commit: https://github.com/apache/kudu/commit/3b2df01c0d75b1244bb45953953144937af8fd1c#diff-55ca72a9af15adcde12468253bbc6a20 -- To view, visit http://gerrit.cloudera.org:8080/9748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469feff940fdd07e1e407c9df49de79ed303151e Gerrit-Change-Number: 9748 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 23:45:30 +0000 Gerrit-HasComments: Yes