Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9744 )
Change subject: IMPALA-6716: Store LDAP options as shell member variables ...................................................................... IMPALA-6716: Store LDAP options as shell member variables When passing comamnd line options to a new instance of the ImpalaShell, we ususally transfer the options to member variables of that new instance. We weren't doing that with all of the LDAP-related options, even though we wanted to access them later. In some environments and under certain conditions, this could then lead to a NameError exception being thrown. This patch takes away any reliance on the original options object returned by parse_args() beyond the __init__() method of the ImpalaShell class, by tranferring all LDAP options to member variables. Also, a test has been added to exercise the code path where the exception had been occurring. Change-Id: I810850f569ef3f4487f7eeba81ca520dc955ac2e Reviewed-on: http://gerrit.cloudera.org:8080/9744 Reviewed-by: Michael Brown <[email protected]> Tested-by: Impala Public Jenkins --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 17 insertions(+), 3 deletions(-) Approvals: Michael Brown: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I810850f569ef3f4487f7eeba81ca520dc955ac2e Gerrit-Change-Number: 9744 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
