David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715: fix stress TPC workload selection ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9758/1/tests/infra/test_infra.py File tests/infra/test_infra.py: http://gerrit.cloudera.org:8080/#/c/9758/1/tests/infra/test_infra.py@1 PS1, Line 1: # Licensed to the Apache Software Foundation (ASF) under one This is awesome. We've needed a place to have tests for the infra code for a long time. Maybe I'm a just crazy dreamer, but someday the contents of this directory might grow. Maybe this file should be renamed test_stress_infra.py, with the hope that it will have siblings someday. http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@91 PS1, Line 91: 71 Why is this number so low? When I list the contents of tpch and tpch_nested workload directories, the number of files matches (22). $ ls -l workloads/tpch/queries/*-q*test | wc -l 22 $ ls -l workloads/tpch_nested/queries/*-q*test | wc -l 22 $ ls -l workloads/tpcds/queries/*-q*test | wc -l 143 -- To view, visit http://gerrit.cloudera.org:8080/9758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da Gerrit-Change-Number: 9758 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 20:51:52 +0000 Gerrit-HasComments: Yes
