Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9716 )
Change subject: IMPALA-4277: Support multiple versions of Hadoop ecosystem ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java File fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java: http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@32 PS8, Line 32: SELECT(AccessConstants.SELECT, 1), > We probably should have use our own constants instead of relying on Sentry' Fredy and I talked about this, and I've not done this right now. He's planning to re-visit this soon. http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@37 PS8, Line 37: INDEX(AccessConstants.INDEX, 32), > I prefer to only have Impala specific action types here. In other words, ev Similarly, I'm not doing this quite yet. http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@49 PS8, Line 49: private String name; > nit: add final Done http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@50 PS8, Line 50: private int code; > nit: add final Done http://gerrit.cloudera.org:8080/#/c/9716/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@67 PS8, Line 67: return null; > It's a bit weird to return null here although that's pretty much how it's i Again: I've not done this yet, to avoid doing too much in this change. -- To view, visit http://gerrit.cloudera.org:8080/9716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a2ab50331986c7394c2bbfd6c865232bca975f7 Gerrit-Change-Number: 9716 Gerrit-PatchSet: 8 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 22:07:25 +0000 Gerrit-HasComments: Yes
