Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 )
Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9680/9/be/src/runtime/io/request-context.h File be/src/runtime/io/request-context.h: http://gerrit.cloudera.org:8080/#/c/9680/9/be/src/runtime/io/request-context.h@376 PS9, Line 376: with a reference to this context. These threads do not hold : /// any locks while reading from HDFS, so we need to prevent the RequestContext from : /// being destroyed underneath them. > Thanks, this comment is clearer. But given that explanation, why is this o The refcounts being updated are on the PerDiskState. I don't fully understand the motivation for this code or all the motivations. It is a two-level refcounting scheme where we decrement num_disks_with_ranges_ once the refcount on the PerDiskState goes to zero. I don't know if there's a reason why it wouldn't work to have simpler scheme where just just have a single refcount on the RequestContext. From what I can tell it looks possible but I might be missing something. -- To view, visit http://gerrit.cloudera.org:8080/9680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87182b6bd51b5fb0b923e7e4c8d08a44e7617db2 Gerrit-Change-Number: 9680 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Mar 2018 22:26:48 +0000 Gerrit-HasComments: Yes
