Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 )
Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9346/2/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/9346/2/be/src/exprs/math-functions-ir.cc@152 PS2, Line 152: // TODO: should we support non-constant seed? > I think this will DCHECK if a negative scale is passed oops, fixed. http://gerrit.cloudera.org:8080/#/c/9346/1/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: http://gerrit.cloudera.org:8080/#/c/9346/1/common/function-registry/impala_functions.py@266 PS1, Line 266: [['sign'], 'DOUBLE', ['DOUBLE'], 'impala::MathFunctions::Sign'], > I think this is a question for Greg. It's mostly about whether this functio Agreed. -- To view, visit http://gerrit.cloudera.org:8080/9346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77541678012edab70b182378b11ca8753be53f97 Gerrit-Change-Number: 9346 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Mar 2018 22:37:20 +0000 Gerrit-HasComments: Yes
