Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 )
Change subject: IMPALA-6694: fix "buffer pool" child profile order ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9749/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/9749/1/be/src/util/runtime-profile.cc@359 PS1, Line 359: while (insert_pos != children_.end() && !found_child) { : found_child = insert_pos->first == child; : ++insert_pos; : } Is it fair to expect that children_ here should end up having the same number of entries as nodes[] after this loop is over ? If so, for entries in nodes[] which don't already exist in child_map_, should we expect the insertion position be "i" in this case ? -- To view, visit http://gerrit.cloudera.org:8080/9749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230f0673edf20a846fdb13191b7a292d329c1bb8 Gerrit-Change-Number: 9749 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 23:47:18 +0000 Gerrit-HasComments: Yes
