Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 )
Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true ...................................................................... Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/9797/1/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/9797/1/be/src/rpc/thrift-server-test.cc@106 PS1, Line 106: FLAGS_prinicpal FLAGS_principal http://gerrit.cloudera.org:8080/#/c/9797/1/be/src/rpc/thrift-server-test.cc@112 PS1, Line 112: FLAGS_be_principal = ""; how does this work to turn off kerberos? http://gerrit.cloudera.org:8080/#/c/9797/1/be/src/testutil/mini-kdc-wrapper.cc File be/src/testutil/mini-kdc-wrapper.cc: http://gerrit.cloudera.org:8080/#/c/9797/1/be/src/testutil/mini-kdc-wrapper.cc@a68 PS1, Line 68: related to other question: why don't we need to skip this stuff still when we want kerberos to be off? -- To view, visit http://gerrit.cloudera.org:8080/9797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7086e5c9b460233e9e957f886141b3e6bba414b Gerrit-Change-Number: 9797 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 16:50:05 +0000 Gerrit-HasComments: Yes
