Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 )
Change subject: IMPALA-6719: Reset metadata database name case sensitivity ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9788/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/9788/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3076 PS2, Line 3076: req.getDb_name().toLowerCase() put the lower-case into the refreshFunctions method. that will make it consistent with the toLowerCase's in the other CatalogServiceCatalog and Catalog methods (they do the toLowerCase in the method, so its not expected for the caller to do so). http://gerrit.cloudera.org:8080/#/c/9788/2/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java: http://gerrit.cloudera.org:8080/#/c/9788/2/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@424 PS2, Line 424: AnalyzesOk(String.format("invalidate metadata %s.%s", dbName, tableName)); just checking that this is testing what's intended, but without the fix, these fail, correct? -- To view, visit http://gerrit.cloudera.org:8080/9788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id880aa559cec0afe8fbb7d33ccce83f7b5e474cb Gerrit-Change-Number: 9788 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 23:47:37 +0000 Gerrit-HasComments: Yes
