Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9822 )
Change subject: IMPALA-6338: Disable flaky bloom filter test ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9822/1/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test File testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test: http://gerrit.cloudera.org:8080/#/c/9822/1/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test@77 PS1, Line 77: #==== > how do we know this is IMPALA-6338? And why is this last case any differen This is the same query as in test_profile_fragment_instances (context is that there was a different but related profile race making this query flaky that I fixed previously, and I added test_profile_fragment_instances to check for actual completeness of the profile, whereas this test only looks for a few bloom filter specific things) This is also the only query that has ever been flaky (afaik) due to this issue, over the many months that IMPALA-6338 has been a bug, presumably because something about it is timing just right to hit the race. In theory, basically any e2e test that has a limit and also checks the runtime profile (eg. most of the tests in this file) could be vulnerable to IMPALA-6338. I'm happy to go through and disable all such tests, but that's potentially a lot of coverage lost and again this particular case is the only one I know of to ever actually be flaky. -- To view, visit http://gerrit.cloudera.org:8080/9822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b88fb8fb7780fc3a7153c05fdc3606145ce35 Gerrit-Change-Number: 9822 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 22:23:18 +0000 Gerrit-HasComments: Yes
