Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 )
Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9819/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java: http://gerrit.cloudera.org:8080/#/c/9819/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java@83 PS3, Line 83: if (partitions.isEmpty()) { I don't think this is correct. It's perfectly legal for partition set to be empty. This does not imply that the table is not partitioned. Further, this problem may not be specific to ALTER TABLE SET LOCATION. I think the issue really is the super class AlterTableSetStmt. If a partition set was given and the target table is not partitioned, then we should throw this error. An Hdfs table is partitioned if HdfsTable.getNumClusteringCols() > 0. -- To view, visit http://gerrit.cloudera.org:8080/9819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I793e827d5cf5b7986bd150dd9706df58da3417f3 Gerrit-Change-Number: 9819 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 04:57:17 +0000 Gerrit-HasComments: Yes
