Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9690
to look at the new patch set (#8).
Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and
KrpcDataStreamSender
......................................................................
IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender
This change implements a couple of improvements to the profiles of
KrpcDataStreamRecvr and KrpcDataStreamSender:
- track pending number of deferred row batches over time in KrpcDataStreamRecvr
- track the number of bytes dequeued over time in KrpcDataStreamRecvr
- track the total time deferred RPCs queues are not empty
- track the number of bytes sent from KrpcDataStreamSender over time
- track the total amount of time spent in KrpcDataStreamSender, including time
spent waiting for RPC completion.
Sample profile of an Exchange node instance:
EXCHANGE_NODE (id=21):(Total: 2s284ms, non-child: 64.926ms, %
non-child: 2.84%)
- ConvertRowBatchTime: 44.380ms
- PeakMemoryUsage: 124.04 KB (127021)
- RowsReturned: 287.51K (287514)
- RowsReturnedRate: 125.88 K/sec
Buffer pool:
- AllocTime: 1.109ms
- CumulativeAllocationBytes: 10.96 MB (11493376)
- CumulativeAllocations: 562 (562)
- PeakReservation: 112.00 KB (114688)
- PeakUnpinnedBytes: 0
- PeakUsedReservation: 112.00 KB (114688)
- ReadIoBytes: 0
- ReadIoOps: 0 (0)
- ReadIoWaitTime: 0.000ns
- WriteIoBytes: 0
- WriteIoOps: 0 (0)
- WriteIoWaitTime: 0.000ns
Dequeue:
BytesDequeued(500.000ms): 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 700.00 KB, 2.00 MB, 3.49
MB, 4.39 MB, 5.86 MB, 6.85 MB
- FirstBatchWaitTime: 0.000ns
- TotalBytesDequeued: 6.85 MB (7187850)
- TotalGetBatchTime: 2s237ms
- DataWaitTime: 2s219ms
Enqueue:
BytesReceived(500.000ms): 0, 23.36 KB, 23.36 KB, 23.36 KB, 23.36
KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36
KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36
KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36 KB, 23.36
KB, 23.36 KB, 23.36 KB, 328.73 KB, 963.79 KB, 1.64 MB, 2.09 MB, 2.76 MB, 3.23 MB
DeferredQueueSize(500.000ms): 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0
- DispatchTime: (Avg: 108.593us ; Min: 30.525us ; Max: 1.524ms ;
Number of samples: 281)
- DeserializeRowBatchTime: 8.395ms
- TotalBatchesEnqueued: 281 (281)
- TotalBatchesReceived: 281 (281)
- TotalBytesReceived: 3.23 MB (3387144)
- TotalEarlySenders: 0 (0)
- TotalEosReceived: 1 (1)
- TotalHasDeferredRPCsTime: 15s446ms
- TotalRPCsDeferred: 38 (38)
Sample sender's profile:
KrpcDataStreamSender (dst_id=21):(Total: 17s923ms, non-child:
604.494ms, % non-child: 3.37%)
BytesSent(500.000ms): 0, 0, 0, 34.78 KB, 34.78 KB, 34.78 KB, 34.78
KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78
KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78 KB, 34.78
KB, 46.54 KB, 46.54 KB, 46.54 KB, 58.31 KB, 58.31 KB, 58.31 KB, 58.31 KB, 58.31
KB, 58.31 KB, 58.31 KB, 974.44 KB, 2.82 MB, 4.93 MB, 6.27 MB, 8.28 MB, 9.69 MB
- EosSent: 3 (3)
- NetworkThroughput: 4.61 MB/sec
- PeakMemoryUsage: 22.57 KB (23112)
- RowsSent: 287.51K (287514)
- RpcFailure: 0 (0)
- RpcRetry: 0 (0)
- SerializeBatchTime: 329.162ms
- TotalBytesSent: 9.69 MB (10161432)
- UncompressedRowBatchSize: 20.56 MB (21563550)
Change-Id: I8ba405921b3df920c1e85b940ce9c8d02fc647cd
---
M be/src/runtime/data-stream-test.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/krpc-data-stream-sender.h
M be/src/runtime/runtime-state.h
M be/src/service/data-stream-service.cc
M be/src/service/data-stream-service.h
M common/protobuf/data_stream_service.proto
10 files changed, 281 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/9690/8
--
To view, visit http://gerrit.cloudera.org:8080/9690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8ba405921b3df920c1e85b940ce9c8d02fc647cd
Gerrit-Change-Number: 9690
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com>
