Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 )
Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT ...................................................................... Patch Set 2: Code-Review+1 (1 comment) @Rodoni, sorry for the late. http://gerrit.cloudera.org:8080/#/c/9030/2/docs/topics/impala_upsert.xml File docs/topics/impala_upsert.xml: http://gerrit.cloudera.org:8080/#/c/9030/2/docs/topics/impala_upsert.xml@71 PS2, Line 71: [<varname>hint_clause</varname>] > Just to confirm: unlike with INSERT, is it correct that the hint for UPSERT No, the optional hints can be placed between UPSERT and INTO. I think the current document is fine to me. -- To view, visit http://gerrit.cloudera.org:8080/9030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9 Gerrit-Change-Number: 9030 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Mar 2018 11:26:37 +0000 Gerrit-HasComments: Yes
