Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9793 )
Change subject: IMPALA-5384, part 1: introduce DmlExecState ...................................................................... Patch Set 6: Code-Review+2 (4 comments) Looks good, should be easier to understand now http://gerrit.cloudera.org:8080/#/c/9793/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/9793/4/be/src/runtime/coordinator.cc@a492 PS4, Line 492: > Thanks for double checking. Yeah, I ended up regenerating the patch from th That's good to know. http://gerrit.cloudera.org:8080/#/c/9793/4/be/src/runtime/coordinator.cc@497 PS4, Line 497: HdfsTableDescriptor* hdfs_table; > Then we'd have to pass in the desc_tbl anyway, right? So, I'd prefer to jus Seems fine in that case. http://gerrit.cloudera.org:8080/#/c/9793/6/be/src/runtime/dml-exec-state.h File be/src/runtime/dml-exec-state.h: http://gerrit.cloudera.org:8080/#/c/9793/6/be/src/runtime/dml-exec-state.h@44 PS6, Line 44: status stats http://gerrit.cloudera.org:8080/#/c/9793/4/be/src/runtime/insert-exec-state.h File be/src/runtime/insert-exec-state.h: http://gerrit.cloudera.org:8080/#/c/9793/4/be/src/runtime/insert-exec-state.h@47 PS4, Line 47: > I renamed this class, but stopped short of trying to restructure the thrift That seems reasonable, at least that's better encapsulated now. -- To view, visit http://gerrit.cloudera.org:8080/9793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4c025917620a7bff2acbeb46464f107ab4b7565 Gerrit-Change-Number: 9793 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 16:34:58 +0000 Gerrit-HasComments: Yes
