Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9800/8/testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test File testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test: http://gerrit.cloudera.org:8080/#/c/9800/8/testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test@326 PS8, Line 326: ==== I think you missed a show functions here.. "VERIFY_IS_NOT_IN" case, to check the drop is successful. -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Mar 2018 20:47:40 +0000 Gerrit-HasComments: Yes
