David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9771 )
Change subject: IMPALA-1071: Distributable python package for impala-shell ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9771/3/shell/packaging/setup.py File shell/packaging/setup.py: http://gerrit.cloudera.org:8080/#/c/9771/3/shell/packaging/setup.py@81 PS3, Line 81: : return package_version : : : setup( : name='impala_shell', > So, this is broken. On my machine, I have impala-shell installed via pip. ( Oy. This is an excellent point, and one that I hadn't considered. Yeah, it looks like we need to make some changes to the code in place. JIRA's to be filed shortly. -- To view, visit http://gerrit.cloudera.org:8080/9771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0422e0c95101400f841ba407a7bd1b2b12d363e0 Gerrit-Change-Number: 9771 Gerrit-PatchSet: 4 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 15:26:56 +0000 Gerrit-HasComments: Yes
