Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9880 )
Change subject: IMPALA-6546: [DOCS] Add the new ODBC functions to docs ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@110 PS2, Line 110: >months_add()</xref></codeph>. > weird line break here (and elsewhere in this file) Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@719 PS2, Line 719: <!--dayname was removed in 2.12.--> > dayname was not removed Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@769 PS2, Line 769: <!-- <codeph>dayofweek(string date)</codeph> --> > remove? Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@1456 PS2, Line 1456: <codeph>longdayname(timestamp date)</codeph> > This function does not exist. I believe you misunderstood Greg's commit mes Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@1473 PS2, Line 1473: <codeph>longmonthname(timestamp date)</codeph> > this is monthname Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@1728 PS2, Line 1728: <!-- <codeph>month(string date)</codeph> --> > remove? Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@2294 PS2, Line 2294: <codeph>shortdayname(timestamp date)</codeph> > This function does not exist. Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@2311 PS2, Line 2311: <codeph>shortmonthname(timestamp date)</codeph> > Function does no exist. Done http://gerrit.cloudera.org:8080/#/c/9880/2/docs/topics/impala_datetime_functions.xml@3040 PS2, Line 3040: <!-- <codeph>weekofyear(string date)</codeph> --> > remove? Done -- To view, visit http://gerrit.cloudera.org:8080/9880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf31b50584628603c0c86ff0772a12ac6ac5c7b6 Gerrit-Change-Number: 9880 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Comment-Date: Sat, 31 Mar 2018 06:29:43 +0000 Gerrit-HasComments: Yes
